Serene

Results 168 comments of Serene

We recently underwent a project-wide format to add consistency, if you could please resolve the conflicts that it has introduced, I can merge the PR.

I've been thinking and I'm not sure that this is the best approach, specifically that most of the code has been added to the downloader module. For one, this ignores...

Yes that is what I meant. Something that can wrap the iterator with as little code in those files as possible and handle any logging calls without changing the master...

I think I am going to make changes to standardize the creation and handling of loggers. This will make your PR much easier if you wait for that.

I'm working on a solution, should be ready soon. The aim will be to decouple the logging so arbitrary logging handlers can be plugged into the RedditConnector class, which will...

Right now that #750 is merged, you should have an easy way to do it. Make an alternative logging handler interface that can handle the messages however you want. Then,...

It's fine, no rush. This will probably hit next release anyway.

So the change in the way loggers are handled mean that you don't have to modify the download loop. You should leave that alone; if everyone who wanted a minor...

Don't start a new PR, just reset your branch to the development commit. Keep it in this thread.

You won't touch the file logger, you're only replacing the stream logger. I don't think it will be that hacky, the example I posted does exactly what you want in...