Sebastian Klähn

Results 100 comments of Sebastian Klähn

Should we use the github discussion forum for discussions instead of using an issue labeled with `discussion` ?

why don't you like it though?

Should I still create one more event like `WebxdcLoadingStateChanged` or should I reuse `MsgChanged`? @r10s @Simon-Laux

Yeah I also thought about that but I decided that since sorting has to be done either way (frontend or backend) it can also be done in the frontend leaving...

@r10s does your thumbs up mean that you understand my reasoning or do you want me to change it?

What is better for the UI? A new event which notifies that update-state has changed or reuse of the MsgChanged Event? @Simon-Laux @r10s @Hocuri

> I'd vote for new event, though I also can see points for reusing the msgs_changed event, but then callbacks that are not needed might be called too, so I...

can I merge this? @r10s

This check is actually sender-wise. So attacker with old or no deltachat-client could still create falsy messages. The check should thus be on the receiving side, right?

> also, i agree, the receiving side is more important than tweaking sending; maybe altering sending is even superfluous then. Makes sense to also strip them on the sending side...