Josiah Noel

Results 202 comments of Josiah Noel

> How many have you got? What do they do? Some for vault and some for aws secret manager. It's not a huge problem to add the disable logic, but...

> merge with ConfigurationSource Not sure about that, while they both load properties, uri loading seems to work more like a custom parser, with uris instead of files types. >...

> how you accomplish profiles cool, I made another PR for that to make it general purpose > To be clear, there is a chance that we take a path...

> > `cmd://` > > The advantage of having this as a URIConfigLoader is that it is then... Yeah I know how it can be useful, I'm more saying that...

@rbygrave what would you have me do?

@rbygrave please review when you get time

Perchance could we at least enable virtual threads for JDK 25+ then, so that no changes need to be made for locking?

Using the git bash, I get ![image](https://github.com/user-attachments/assets/26427371-d419-4b5e-b4d1-34343f1a03e6) ![image](https://github.com/user-attachments/assets/67f7147c-973f-420d-af6a-5f0b321b6cc2)

Consistently with these two

![image](https://github.com/user-attachments/assets/37db4a96-1fea-420e-a846-5fd598ec22dc) I get the same error with JDK 22 as well