minecraft-mod-manager icon indicating copy to clipboard operation
minecraft-mod-manager copied to clipboard

Add `downgrade` as `update` should only update mods, never downgrade

Open craftycorvid opened this issue 3 years ago • 2 comments

Describe the bug

Minecraft Mod Manager is downloading an older version of Sodium than the one installed.

sodium
    🟢 Updated 0.3.0+build.483 -> 0.2.0+build.4

The build I have installed is a newer build from github with a higher version number. Still, the latest version available on Curse/Modrinth is being downloaded.

Steps to reproduce

Steps to reproduce the behavior:

  1. Installed latest sodium dev build manually from github
  2. Ran mcman update

Expected Behavior

Minecraft Mod Manager should compare the installed version number to the latest available version and only download an update if the number is greater.

Info

  • OS: Windows 10
  • Python --version: 3.9.6
  • minecraft-mod-manager --version: 1.2.4

craftycorvid avatar Jul 07 '21 22:07 craftycorvid

Thanks for reporting 🙂 This is a bit of a tricky situation... While this is the expected behavior (since it's the only way to downgrade mods), I see the problem. I think I have a good solution down below 🙂

Scenario where you actually would want it to be downgraded

  1. You have an old MC version 1.12 (playing with some old mods).
  2. There have been updates on mods to the 1.12 version
  3. You accidentally run mcman update and it updates all mods to 1.17
  4. To fix this you can run mcman update -v 1.12

Possible solutions

  1. Ask before downgrading Instead of automatically downgrading, ask the user for each mod that would be downgraded if they want to do that or not.
  2. mcman downgrade command that allows the user to downgrade mods, which would solve the above scenario
  3. mcman update --downgrade option that allows the upgrade command to downgrade the mods.

I'm leaning more into the actual mcman downgrade solution. Since I guess the confusion is partly that the update command should not be able to downgrade mods.

Senth avatar Jul 08 '21 14:07 Senth

This will probably not be necessary after #38 has been released. Since the Minecraft version will be handled automatically.

I'd like to keep it here though since it might still be viable to be able to set a specific version (similar to downgrade).

Senth avatar Aug 10 '21 20:08 Senth