minecraft-mod-manager
minecraft-mod-manager copied to clipboard
Add `downgrade` as `update` should only update mods, never downgrade
Describe the bug
Minecraft Mod Manager is downloading an older version of Sodium than the one installed.
sodium
🟢 Updated 0.3.0+build.483 -> 0.2.0+build.4
The build I have installed is a newer build from github with a higher version number. Still, the latest version available on Curse/Modrinth is being downloaded.
Steps to reproduce
Steps to reproduce the behavior:
- Installed latest sodium dev build manually from github
- Ran
mcman update
Expected Behavior
Minecraft Mod Manager should compare the installed version number to the latest available version and only download an update if the number is greater.
Info
- OS: Windows 10
- Python --version: 3.9.6
- minecraft-mod-manager --version: 1.2.4
Thanks for reporting 🙂 This is a bit of a tricky situation... While this is the expected behavior (since it's the only way to downgrade mods), I see the problem. I think I have a good solution down below 🙂
Scenario where you actually would want it to be downgraded
- You have an old MC version 1.12 (playing with some old mods).
- There have been updates on mods to the 1.12 version
- You accidentally run
mcman update
and it updates all mods to 1.17 - To fix this you can run
mcman update -v 1.12
Possible solutions
- Ask before downgrading Instead of automatically downgrading, ask the user for each mod that would be downgraded if they want to do that or not.
-
mcman downgrade
command that allows the user to downgrade mods, which would solve the above scenario -
mcman update --downgrade
option that allows theupgrade
command to downgrade the mods.
I'm leaning more into the actual mcman downgrade
solution. Since I guess the confusion is partly that the update
command should not be able to downgrade mods.
This will probably not be necessary after #38 has been released. Since the Minecraft version will be handled automatically.
I'd like to keep it here though since it might still be viable to be able to set a specific version (similar to downgrade).