IOTstack icon indicating copy to clipboard operation
IOTstack copied to clipboard

Option max-size not working with docker journald logging

Open weissm opened this issue 4 years ago • 7 comments

When running the standard generated docker-compose file, the "max-size" option causes an error @ docker-compose when working with journald logging in docker. When removing this in the generated docker-compose everything works fine.

I found this defined in the templates and wondering if it shall be removed there or if there is a generic way to handle this?

Thanks in advance, Matthias

weissm avatar Sep 23 '20 06:09 weissm

I'm really confused

$ grep -iR "max-size" ~/IOTstack/* 2>/dev/null 
$

No hits in my installation so where are you seeing "max-size"?

Paraphraser avatar Sep 23 '20 08:09 Paraphraser

Thanks for quick feedback. I was refering to the experimental branch, e.g. https://github.com/SensorsIot/IOTstack/blob/experimental/.templates/openhab/service.yml

logging: options: max-size: "5m" max-file: "3"

thx!

weissm avatar Sep 23 '20 09:09 weissm

OK. For experimental branch issues, you need to wait for @Slyke to respond.

Paraphraser avatar Sep 23 '20 10:09 Paraphraser

Hey @weissm what version of docker and docker-compose are you running? What is the exact error you're getting? I added in these options so that the log files don't grow indefinitely on Raspberry Pis. I can create a option to turn them off if it is causing errors.

Slyke avatar Sep 28 '20 09:09 Slyke

Thank you very much for getting back. Here is the versions I am running.

  • docker-compose version 1.26.0, build unknown
  • Docker version 19.03.13, build 4484c46 I guess the issue in my set up is the use journald logging. The solution you are proposing should solve it.

weissm avatar Sep 29 '20 06:09 weissm

Awesome. Everything looks up to date. I'll add in an option to turn logging on and off, but it'll be after experimental has been merged into master, since it's a giant PR as it is.

Slyke avatar Oct 06 '20 05:10 Slyke

Understood – thanks!

From: Slyke [email protected] Sent: Dienstag, 6. Oktober 2020 07:46 To: SensorsIot/IOTstack [email protected] Cc: Matthias Weiss [email protected]; Mention [email protected] Subject: Re: [SensorsIot/IOTstack] Option max-size not working with docker journald logging (#120)

Awesome. Everything looks up to date. I'll add in an option to turn logging on and off, but it'll be after experimental has been merged into master, since it's a giant PR as it is.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SensorsIot/IOTstack/issues/120#issuecomment-704041929 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAGSHHYFA32Q2EQKSYAD43SJKVJPANCNFSM4RWT7Y7Q . https://github.com/notifications/beacon/ABAGSHEA76JPXOCSEHRGZATSJKVJPA5CNFSM4RWT7Y72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFH3NHSI.gif

weissm avatar Oct 06 '20 06:10 weissm