hypixel-discord-chat-bridge icon indicating copy to clipboard operation
hypixel-discord-chat-bridge copied to clipboard

Added the Weight Command

Open KlaasNiphaas opened this issue 3 years ago • 2 comments

Just added a weight command.

KlaasNiphaas avatar Aug 07 '21 17:08 KlaasNiphaas

A few suggestions:

  • In order to make adding new commands easier to add, it may be worth putting all api related methods inside their own class and adding it as a property on either the App or Minecraft objects, so to get the data you could just add the line const playerData = this.minecraft.apiHandler.getPlayerData(<ign>) or something similar.

I don't fully understand this code (with all the this. and classes) but i'll try.

KlaasNiphaas avatar Aug 08 '21 10:08 KlaasNiphaas

A few suggestions:

  • In order to make adding new commands easier to add, it may be worth putting all api related methods inside their own class and adding it as a property on either the App or Minecraft objects, so to get the data you could just add the line const playerData = this.minecraft.apiHandler.getPlayerData(<ign>) or something similar.

I don't fully understand this code (with all the this. and classes) but i'll try.

I tried for quite some time but i can't make it work :/

KlaasNiphaas avatar Aug 12 '21 11:08 KlaasNiphaas