telescope icon indicating copy to clipboard operation
telescope copied to clipboard

Fixes #3692 by adding database info to `environment-setup` file

Open SerpentBytes opened this issue 2 years ago • 6 comments

Issue This PR Addresses

Fix #3692 by including information on properly seeding the database in the environment-setup file.

Type of Change

  • [ ] Bugfix: Change which fixes an issue
  • [ ] New Feature: Change which adds functionality
  • [x] Documentation Update: Change which improves documentation
  • [ ] UI: Change which improves UI

Description

This PR adds information on how to seed PostgresSQL locally for testing purposes properly.

Steps to test the PR

  • check the updated environment-setup file.

Checklist

  • [ ] Quality: This PR builds and passes our npm test and works locally
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • [x] Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

SerpentBytes avatar Oct 20 '22 17:10 SerpentBytes

gitpod-io[bot] avatar Oct 20 '22 17:10 gitpod-io[bot]

@manekenpix I filed the issue and created the PR. Please assign someone else to review this PR.

SerpentBytes avatar Oct 20 '22 17:10 SerpentBytes

You're being assigned the PR, meaning you're responsible for this PR, not being assigned to review.

Also, this image I'm guessing is most likely from not rebasing correctly. If rebased right, the message would not appear, and there would only be 1 commit to this PR.

RC-Lee avatar Oct 20 '22 18:10 RC-Lee

@RC-Lee, Sorry, my bad. :)

SerpentBytes avatar Oct 20 '22 18:10 SerpentBytes

I do my setup a bit out of the status quo, but I'm wondering if you've tested yourself? (Including deleting the redis cache (redis-data) and starting from scratch) Another good way to have this tested is if you could ask one of your current classmates to go through it line by line and see if they can get Telescope started up.

Just from what I've experienced, the db scripts will not be able to run correctly if the db containers aren't running. Thought it'd be worth pointing out.

RC-Lee avatar Oct 20 '22 19:10 RC-Lee

If you do the setup using the environment-setup as a guide, you would most likely run into database issues. I pointed out this problem in the Telescope channel, and @humphd suggested filing an issue for it.

SerpentBytes avatar Oct 20 '22 20:10 SerpentBytes

How is progress on this? I just ran into this issue and this would be a nice to have!

AmasiaNalbandian avatar Oct 26 '22 15:10 AmasiaNalbandian

How is progress on this? I just ran into this issue and this would be a nice to have!

I am working on this.

SerpentBytes avatar Oct 26 '22 16:10 SerpentBytes

These steps did not seem to work for the db...

AmasiaNalbandian avatar Oct 26 '22 16:10 AmasiaNalbandian

These steps did not seem to work for the db...

Yes, because it's WIP. In the meantime, users can setup their environment using steps not introduced through this PR.

SerpentBytes avatar Oct 26 '22 17:10 SerpentBytes

@manekenpix Thank you for all your help.

SerpentBytes avatar Oct 26 '22 21:10 SerpentBytes