telescope icon indicating copy to clipboard operation
telescope copied to clipboard

Improve Dependency Page CSS

Open Eakam1007 opened this issue 2 years ago • 1 comments

Issue This PR Addresses

Fixes #3535

Type of Change

  • [ ] Bugfix: Change which fixes an issue
  • [ ] New Feature: Change which adds functionality
  • [ ] Documentation Update: Change which improves documentation
  • [x] UI: Change which improves UI

Description

Updated the CSS for the dependency page table to make dependencies stand out more:

  • Increased font size for dependency names
  • Changed font family to Spartan
  • Also changed the color of the border separating dependencies so it is not as bright in dark mode

No tests were added since this is a small css change.

Current: image image

Updated: image image

Steps to test the PR

  • Run telescope locally
  • Navigate to /dependencies
  • Check the updated styles for dependency names and the border for both light theme and dark theme

Checklist

  • [x] Quality: This PR builds and passes our npm test and works locally
  • [x] Tests: This PR includes thorough tests or an explanation of why it does not
  • [x] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • [x] Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Eakam1007 avatar Oct 09 '22 02:10 Eakam1007

gitpod-io[bot] avatar Oct 09 '22 02:10 gitpod-io[bot]

@Eakam1007 can we get this finished today and squashed/rebased so that we can land before midnight?

humphd avatar Oct 31 '22 13:10 humphd

@Eakam1007 Can you squash commit? Thank you

Kevan-Y avatar Oct 31 '22 16:10 Kevan-Y

@Eakam1007 Can you squash commit? Thank you

~~I tried squashing but I can't seem to get it work. Sorry but could I get some help here?~~ Edit: Had to reload a few times to see the changes

Eakam1007 avatar Oct 31 '22 17:10 Eakam1007

@Kevan-Y can you give this your blessing and merge once you're happy?

humphd avatar Oct 31 '22 18:10 humphd