telescope icon indicating copy to clipboard operation
telescope copied to clipboard

Fix typescript eslint type checking errors

Open DukeManh opened this issue 2 years ago • 2 comments

What happened: When I was working on #3683, I realized typescript-eslint and recommended-requiring-type-checking config is not extended in src/web/app eslint config which made us miss quite a few of the lint errors.

We need to fix these errors with the updated config.

module.exports = {
  extends: [
    '@senecacdot/eslint-config-telescope',
++    'plugin:@typescript-eslint/recommended',
++    'plugin:@typescript-eslint/recommended-requiring-type-checking',
  ],
...
  parserOptions: {
    ecmaFeatures: {
      jsx: true,
    },
    ecmaVersion: 2021,
++    project: './tsconfig.json',
++    tsconfigRootDir: './',
  },

...
};
image

What should have happened:

How to reproduce it (as precise as possible):

Anything else we need to know?:

Environment:

  • OS:
  • Browser:

DukeManh avatar Oct 06 '22 16:10 DukeManh

This would be a great issue for someone to work on for Hacktoberfest, or to pick one of the files it reports and fix errors in that.

humphd avatar Oct 06 '22 16:10 humphd

I think this issue is quite involved and touches more than 30+ files, so I'll assign myself here.

cindyorangis avatar Oct 06 '22 17:10 cindyorangis