telescope icon indicating copy to clipboard operation
telescope copied to clipboard

use module aliases vs relative paths

Open DukeManh opened this issue 2 years ago • 5 comments

When the project grows deeper, more ../ are required in the relative import paths to import modules so this configs TS path aliases, that map to certain absolute paths.

Type of Change

  • [ ] Bugfix: Change which fixes an issue
  • [ ] New Feature: Change which adds functionality
  • [ ] Documentation Update: Change which improves documentation
  • [ ] UI: Change which improves UI

Description

Steps to test the PR

Checklist

  • [ ] Quality: This PR builds and passes our npm test and works locally
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • [ ] Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

DukeManh avatar Oct 06 '22 04:10 DukeManh

gitpod-io[bot] avatar Oct 06 '22 04:10 gitpod-io[bot]

Search tests will fail while I'm updating ES

RC-Lee avatar Oct 06 '22 04:10 RC-Lee

We'd need to fix #3690 first to pass eslint.

DukeManh avatar Oct 06 '22 16:10 DukeManh

@DukeManh do you want this in before tonight (end of Hacktoberfest)? If so, what does it need?

humphd avatar Oct 31 '22 13:10 humphd

@humphd, I needed to add 'plugin:@typescript-eslint/recommended' for eslint to pass but then found out there is more work to do in #3690 if I make that change.

DukeManh avatar Nov 03 '22 01:11 DukeManh