telescope icon indicating copy to clipboard operation
telescope copied to clipboard

Published 20 hours ago • verified publisher icon Seneca-CDOT

Migrate MUI from v4 to v5

Open cindyorangis opened this issue 3 years ago • 9 comments

Related to #3177

From https://github.com/Seneca-CDOT/telescope/issues/3177#issuecomment-1065890466

MUI v4 is deprecated and has significantly decreased developer happiness working with it. We need to update MUI to v5

Via Slack @AmasiaNalbandian has agreed to work this until she dies so we can count on her to support MUI (or we rip it out one day, who knows)

cindyorangis avatar Mar 13 '22 00:03 cindyorangis

Pre-3.0 or Post-3.0? Seems big.

humphd avatar Mar 13 '22 00:03 humphd

I think post would be best, but most preferably before 3.1....

AmasiaNalbandian avatar Mar 13 '22 00:03 AmasiaNalbandian

Just read up on migrating MUI v4 to v5. Lots of breaking changes. It honestly feels similar to porting Gatsby.js to Next.js. We will need to plan out a strategy for this migration.

cindyorangis avatar Mar 13 '22 02:03 cindyorangis

We should probably wait until we can freeze the front-end UI long enough to do the migration without also having to port changes. We might be able to do that prior to 3.0. Let's discuss in your upcoming call.

humphd avatar Mar 13 '22 14:03 humphd

I've started a project board for this to help organize things

Very WIP https://github.com/orgs/Seneca-CDOT/projects/10

cindyorangis avatar Mar 15 '22 06:03 cindyorangis

This PR went in last week

What does this mean? I think I was initially confused by the issue. Is this issue to upgrade UI to use more enhanced components from v5? @cindyledev

AmasiaNalbandian avatar Apr 05 '22 15:04 AmasiaNalbandian

I want to move this to start in December - I am assuming most students will be off and not touch most of the UI. We can do this using the project board added by Cindy and do each component at a time.

I was considering starting this now, and just updating my branches everyday but I'm not sure how that will go...

AmasiaNalbandian avatar Nov 02 '22 00:11 AmasiaNalbandian

Sure that works. I'm planning to work on version 4.0 in the winter with the new OSD700/DPS911 group, so this would be good to do in between.

humphd avatar Nov 02 '22 00:11 humphd

From what I see, we already have v5 installed. I think we can start doing it in parts with some using the depreciated components and updating it. Do you think this would work @humphd?

Also, can we migrate to use styled components? Or is that TOO big of a change?

AmasiaNalbandian avatar Nov 02 '22 00:11 AmasiaNalbandian