telescope icon indicating copy to clipboard operation
telescope copied to clipboard

Remove Feed related code from Posts Service

Open humphd opened this issue 3 years ago • 8 comments

In #1838 we are adding a Posts Service, and it's reusing code for Redis that currently deals with both Feeds and Posts. We can strip the Feeds logic out of there, and move it to #1828. See, for example: src/api/posts/src/storage.js

humphd avatar Mar 12 '21 12:03 humphd

Somewhat related, we'll have to figure out if the logic for adding posts needs to stay there, or get moved out to another service too. See #1865.

humphd avatar Mar 12 '21 12:03 humphd

I assume this would involve the post parsing service (#1828) since that service will use parts with both feed and posts

HyperTHD avatar Mar 12 '21 20:03 HyperTHD

@humphd Is this still a problem?

sirinoks avatar Feb 24 '22 00:02 sirinoks

Given that feeds will live in Supabase, we should probably remove this, yes. It's still needed.

humphd avatar Feb 24 '22 00:02 humphd

Related to supabase.

aserputov avatar Feb 24 '22 13:02 aserputov

We should figure out what is actually calling the feeds route. I suspect it's the old parser, which is going away. The new parser can talk directly to Supabase (cc @TueeNguyen).

humphd avatar Feb 24 '22 13:02 humphd

You have to also change the relationship between a feed and a post. Right now, a post must have a feed, so the frontend cannot load any posts that doesn't have a feed, which is why I didn't remove the feed related code when I made this service. I don't remember if the feeds routes were needed, probably not, but the feed class and methods used there definitely are atm, so you have to consider how to update that with supabase without incurring any sort of crash on the frontend due to missing required information @TueeNguyen

HyperTHD avatar Feb 26 '22 04:02 HyperTHD

This can happen post-3.0

humphd avatar Apr 20 '22 14:04 humphd