Semantic-UI
Semantic-UI copied to clipboard
[Table] Anchors in `.selectable` cells shouldn’t override compact variations
Hi there,
I have two (very) minor issues to report.
Adding the "selectable" class to a cell in a "very compact" table changes how the text is aligned. Here is the jsfiddle: https://jsfiddle.net/wotut2tr/2/
Additionally, once a link is added to that cell it seems to remove the "compact" attribute from the table. Here is the jsfiddle: https://jsfiddle.net/k4nkpjqb/6/
Thanks. Appreciate the work on Semantic-UI very much.
Hi @djscales, the first issue is universal across all variations and seems to be intentional. Right now td.selectable
overrides a cell’s padding and sets it to zero, and without it, a td.selectable > a
element wouldn’t be filling an entire cell. Not sure if it should be dealt with on the framework level, because a possible fix might include the renaming of td.selectable
, which isn’t backwards compatible, and something else will bloat the source a tiny bit. In any case, we probably shouldn’t be tracking two issues in one thread, so if you’d like the first issue to be addressed, please report it separately.
There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.
However, PRs for this issue will of course be accepted and welcome!
If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!
Both issues are fixed in the community fork Fomantic-UI. The second issue was freshly fixed by https://github.com/fomantic/Fomantic-UI/pull/2090
See your adjusted jsfiddles here
- issue https://jsfiddle.net/lubber/cvkr85bx/
- issue https://jsfiddle.net/lubber/ensmy25b/7/