Semantic-UI-React
Semantic-UI-React copied to clipboard
feat(Dropdown): Adds support for closeOnChange when removing items
Fixes #4491
This PR adds support for closeOnChange for item removal via label and backspace in a Multiple Selection Dropdown
💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:
- Run
yarn lintlocally to catch formatting errors. This will fix some errors automatically, commit and push any changes. - Run
yarn testlocally to catch errors. This ensures all components still behave as they should. - Run
yarn startto run the doc site locally and try a few pages, ensuring everything is in good working order. - Include tests when adding/changing behavior.
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| semantic-ui-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 29, 2024 4:52pm |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.50%. Comparing base (
1623c8d) to head (34dedbd).
Additional details and impacted files
@@ Coverage Diff @@
## master #4492 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 186 186
Lines 3465 3467 +2
=======================================
+ Hits 3448 3450 +2
Misses 17 17
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
one note - i called this a feature, but it could be argued it is actually a bugfix - it's not obvious what the intended purpose of closeOnChange is but I'd argue it should be to close on ANY change (including removal) not just additions, hence this PR