Semantic-UI-React icon indicating copy to clipboard operation
Semantic-UI-React copied to clipboard

Implement closeOnChange for removeItemOnBackspace and handleLabelRemove

Open stevenrick opened this issue 1 year ago • 1 comments

Feature Request

Problem description

I noticed that #1252 implemented an optional prop closeOnChange for Multiple Selection Dropdown that only works when selecting an item to add but does not apply when removing an item.

Proposed solution

Add this.closeOnChange(e) to the end of the following functions: removeItemOnBackspace and handleLabelRemove which are both in src/modules/Dropdown/Dropdown.js

MVP

Proof of concept (showing the problem): https://codesandbox.io/p/sandbox/semantic-ui-react-closeonchange-poc-69t37k Add items to selection, then remove items via label or backspace while dropdown is focused/open and element will remain open

Forked, Cloned, Installed, and Tested in PR #4492

stevenrick avatar Aug 29 '24 16:08 stevenrick

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Aug 29 '24 16:08 welcome[bot]