Semantic-UI-React icon indicating copy to clipboard operation
Semantic-UI-React copied to clipboard

fix(Dropdown): Fix getSelectedIndexAfterMove recursion error

Open MitchellNeedham opened this issue 1 year ago • 3 comments

Fix for #4462

MitchellNeedham avatar Feb 10 '24 10:02 MitchellNeedham

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Feb 10 '24 10:02 welcome[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semantic-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 11:04am

vercel[bot] avatar Feb 10 '24 10:02 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c579cab) 99.50% compared to head (efc005d) 99.50%. Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4463   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files         186      186           
  Lines        3465     3467    +2     
=======================================
+ Hits         3448     3450    +2     
  Misses         17       17           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 10 '24 10:02 codecov[bot]