Semantic-UI-React
Semantic-UI-React copied to clipboard
fix(TransitionablePortal): fix onClose call
Fixes #4056.
💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:
- Run
yarn lintlocally to catch formatting errors. This will fix some errors automatically, commit and push any changes. - Run
yarn testlocally to catch errors. This ensures all components still behave as they should. - Run
yarn startto run the doc site locally and try a few pages, ensuring everything is in good working order. - Include tests when adding/changing behavior.
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Codecov Report
Merging #4334 (1fe1aac) into master (bb2db59) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #4334 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 180 180
Lines 3241 3243 +2
=======================================
+ Hits 3233 3235 +2
Misses 8 8
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ddons/TransitionablePortal/TransitionablePortal.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ff70355...1fe1aac. Read the comment docs.