Semantic-UI-Meteor icon indicating copy to clipboard operation
Semantic-UI-Meteor copied to clipboard

add ".import.less" to overrides and variables files

Open sircharleswatson opened this issue 9 years ago • 6 comments

This will allow people to use semantic:ui inside a Meteor package and will fix a lot of the problems with getting that to work properly.

This is dependent on the pull request just made here: https://github.com/Semantic-Org/Semantic-UI-Meteor-Data/pull/1

This will also fix these issues: #63, #62, and #52

This will possibly fix other issues as well.

With the .import.less extension on the *.overrides and *.variables files, it will work perfectly whether the semantic:ui package is being depended upon in another package, or if it is added directly to an app.

sircharleswatson avatar Sep 24 '15 19:09 sircharleswatson

Awesome! Just tried it by checking out your forks (Semantic-UI-Meteor and Semantic-UI-Meteor-Data) and it works perfectly with the official Less package! :+1:

wursttheke avatar Sep 25 '15 12:09 wursttheke

You can also edit the less package to add .import and .variables as acceptable file types.

jlukic avatar Sep 25 '15 20:09 jlukic

@jlukic I think it would take a lot longer for MDG to accept changes to their less package, unfortunately. What do you think would be the best option?

sircharleswatson avatar Sep 25 '15 20:09 sircharleswatson

I'm currently monkeypatching mdg less packages. I might talk to someone at meteor about this when i get a chance.

I think this is an alright solution but it will require people to modify their site/ files as well. Which in most cases would have to be manual.

jlukic avatar Sep 25 '15 21:09 jlukic

@jlukic That makes sense. According to the Less docs, if you pass any file to it that doesn't have .less or .import.less it's supposed to treat it like less. So it'd be good if the MDG Less package had a way to specify certain files to process as Less files.

I needed a quick solution so the easiest way was to change the file extensions here. but if this isn't the best place to do it, I'm fine with that :)

sircharleswatson avatar Sep 26 '15 14:09 sircharleswatson

@sircharleswatson wow thanks man, it will help us a lot. App reloading times in development mode now takes forever which is insane :) Really looking forward for new Semantic-UI version with the fix

v3rron avatar Sep 27 '15 16:09 v3rron