Semantic-UI-LESS icon indicating copy to clipboard operation
Semantic-UI-LESS copied to clipboard

Basic Blue Circular Label has Blue Background

Open kerry-money opened this issue 6 years ago • 4 comments

I notice label has this rule:

.ui.basic.blue.label { background-color: @basicBackground !important; color: @blue !important; border-color: @blue !important; }

@basicBackground is a variable designed to specify the whole background property - not simply a color (none @white). Therefore, this is an invalid value and it falls back to the blue background.

I believe background-color should simply be set to @white for this rule. I made an override locally, but am thinking to submit a PR for this.

Without new Rule: without_rule

With new Rule: with_new_rule

kerry-money avatar Jul 17 '18 14:07 kerry-money

https://github.com/Semantic-Org/Semantic-UI-LESS/blob/1cff5db70bcf13d9f715bbacd7a3be7ba0ad1e99/themes/default/elements/label.variables#L106 https://github.com/Semantic-Org/Semantic-UI-LESS/blob/1cff5db70bcf13d9f715bbacd7a3be7ba0ad1e99/definitions/elements/label.less#L784-L788

I think that background-color: @basicBackground !important; have to be changed to background: @basicBackground !important;

rayronvictor avatar Jul 23 '18 18:07 rayronvictor

This happens to all colours of basic labels (not just blue)

scottwarren avatar Jul 26 '18 21:07 scottwarren

Someone already created a Pull Request. Hope it merged soon. https://github.com/Semantic-Org/Semantic-UI/pull/6440

co2meal avatar Aug 24 '18 07:08 co2meal

Fixed in the community fork Fomantic-UI since 2.6.0

lubber-de avatar Dec 19 '21 20:12 lubber-de