Semantic-UI-CSS
Semantic-UI-CSS copied to clipboard
Brand Icons not included.
Brand icons do not seem to be included in the build. If this is intended behavior, please document it.
https://github.com/Semantic-Org/Semantic-UI-CSS/blob/980e4be53fc3b3e45ee1fb09f44b41eaadab4f37/package.js#L18-L32 should definitely be put in there.
small work around until it get's fixed for your ember-cli-build.js:
'eot,svg,ttf,woff,woff2'.split(',').forEach(type => {
['brand', 'outline'].forEach(asset => {
app.import(`node_modules/semantic-ui-css/themes/default/assets/fonts/${asset}-icons.${type}`, {
destDir: 'assets/themes/default/assets/fonts'
});
});
});
Lines 18 to 32 in 980e4be
api.addFiles([ // icons 'themes/default/assets/fonts/icons.eot', 'themes/default/assets/fonts/icons.svg', 'themes/default/assets/fonts/icons.ttf', 'themes/default/assets/fonts/icons.woff', 'themes/default/assets/fonts/icons.woff2',
// flags 'themes/default/assets/images/flags.png',
// release 'semantic.css', 'semantic.js' ], 'client');
should definitely be put in there. small work around until it get's fixed for your ember-cli-build.js:
'eot,svg,ttf,woff,woff2'.split(',').forEach(type => { ['brand', 'outline'].forEach(asset => { app.import(`node_modules/semantic-ui-css/themes/default/assets/fonts/${asset}-icons.${type}`, { destDir: 'assets/themes/default/assets/fonts' }); }); });
How do I fix this if I'm not using ember-cli?
I’ll fix the github admin build tools to generate the correct css repo files in the next patch. This build is automatically produced using tools from the main repo.
Any updates on possibly when the update will be pushed?
Since this is probably not getting fixed in the near future (if ever), does anyone have a workaround?
Since this is probably not getting fixed in the near future (if ever), does anyone have a workaround?
Could try this: https://github.com/fomantic/Fomantic-UI-CSS
Nope, using fomantic's CSS doesn't add the icons i need, those icons are missing from Fomantic's website too.
Nope, using fomantic's CSS doesn't add the icons i need, those icons are missing from Fomantic's website too.
Which brand icons are missing? This is what I see.
Facebook, instagram, twitter, linkedin for example are missing
Facebook, instagram, twitter, linkedin for example are missing
I see them.
Hmm i think my cache was messed up, i'll see if i can get it working with Fomantic.
Just in case this happens to someone; the semantic UI icons are working but they were getting blocked by my ad blocker.