selenium icon indicating copy to clipboard operation
selenium copied to clipboard

Introduce select support for js

Open luukvhoudt opened this issue 3 years ago • 8 comments

Description

This PR is the start of the implementation for the select element support class for the JavaScript client. The global documentation already exists and can be found here. The lag of this feature is already noted in the code example boxes on this page. However issue #8721 also mentions this, however it was never solved because the issue lags a template.

Motivation and Context

Crucial feature for testing and automating.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [X] I have read the contributing document.
  • [X] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

luukvhoudt avatar Mar 08 '21 20:03 luukvhoudt

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: AutomatedTester
:x: Luuk van Houdt


Luuk van Houdt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 08 '21 20:03 CLAassistant

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Mar 08 '21 20:03 sonarqubecloud[bot]

this seems a great start. Let us know when the tests are completed and we can see about merging this PR

AutomatedTester avatar Mar 10 '21 11:03 AutomatedTester

@luukvhoudt Are you going to be able to finish this PR?

AutomatedTester avatar Jul 15 '21 18:07 AutomatedTester

@luukvhoudt Are you going to be able to finish this PR?

@AutomatedTester unfortunately not anytime soon, currently I also cannot really make an estimate when I will be able to finish this PR.

luukvhoudt avatar Jul 15 '21 21:07 luukvhoudt

Codecov Report

Merging #9244 (3c976d5) into trunk (ad11a61) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #9244   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files          82       82           
  Lines        5445     5445           
  Branches      247      247           
=======================================
  Hits         2401     2401           
  Misses       2797     2797           
  Partials      247      247           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad11a61...3c976d5. Read the comment docs.

codecov-commenter avatar Jul 19 '21 13:07 codecov-commenter

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 19 '21 13:07 sonarqubecloud[bot]

@AutomatedTester @diemol @harsha509 should selenium-webdriver have all those elements wrappers? maybe it would be better to create separate package?

potapovDim avatar Nov 05 '21 16:11 potapovDim

Closing in favor of https://github.com/SeleniumHQ/selenium/commit/35adf8bef56cd5efc166feda96224b74800b8503

diemol avatar Aug 18 '22 13:08 diemol