selenium icon indicating copy to clipboard operation
selenium copied to clipboard

[🐛 Bug]: Breaking change in #16412 to the HttpClient interface

Open joerg1985 opened this issue 4 weeks ago • 4 comments

Description

Okay i am pretty late with this one, as it was merged in october. But this is a breaking change without any need, so there should be default implementations to the new methods.

In general, why do we hide the implementation behind an interface to later on expose methods enforcing a specific client implementation?

Additionally all the workarounds added to JdkHttpClients are bypassed by this methods, instead of just passing the BodyHandler implementation to use into the regular code path.

Reproducible Code

N/A

joerg1985 avatar Dec 03 '25 12:12 joerg1985

@joerg1985, thank you for creating this issue. We will troubleshoot it as soon as we can.

Selenium Triage Team: remember to follow the Triage Guide

selenium-ci avatar Dec 03 '25 12:12 selenium-ci

What PR or commit are you referring to?

diemol avatar Dec 03 '25 12:12 diemol

#16412 sorry i only mentioned it in the title

joerg1985 avatar Dec 03 '25 12:12 joerg1985

@manuelsblanco can you please help us there? @joerg1985's feedback makes sense.

diemol avatar Dec 03 '25 13:12 diemol