[rb] mark low level bidi implementation as private api
User description
We all know anyone can do whatever they want with Ruby objects, but the source code should indicate which things we should be trying to use.
PR Type
Documentation
Description
-
Mark low-level BiDi implementation classes as private API
-
Add
@api privateYARD documentation tags to internal modules -
Clarify recommended public API alternatives in class documentation
-
Improve code documentation with module descriptions
Diagram Walkthrough
flowchart LR
BiDi["BiDi Module Classes"]
BiDi -->|"Add @api private tags"| Docs["YARD Documentation"]
BiDi -->|"Add usage guidance"| Comments["Class Comments"]
Comments -->|"Reference public APIs"| Public["driver.manager, driver.navigate, driver.script"]
File Walkthrough
| Relevant files | |||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Documentation | 13 files
|
PR Compliance Guide 🔍
Below is a summary of compliance checks for this PR:
| Security Compliance | |||||||||||
| ⚪ | Unsafe script usage guidanceDescription: The comment suggests accessing logging via Referred Code
| ||||||||||
| Ticket Compliance | |||||||||||
| ⚪ | 🎫 No ticket provided
Codebase Duplication Compliance | ⚪ | Codebase context is not definedFollow the guide to enable codebase context checks. Custom Compliance | ⚪ | No custom compliance providedFollow the guide to enable custom compliance check.
|
| |||||
Compliance status legend
🟢 - Fully Compliant🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label
PR Code Suggestions ✨
Explore these optional code suggestions:
| Category | Suggestion | Impact |
| Possible issue |
Fix incorrect hash mutation during iterationIn rb/lib/selenium/webdriver/bidi/network/cookies.rb [28-35]
Suggestion importance[1-10]: 9__ Why: The suggestion correctly identifies a critical bug where the | High |
| Learned best practice |
Fix inaccurate module commentUpdate the comment to accurately reflect that this class implements the Network rb/lib/selenium/webdriver/bidi/network.rb [24-25]
Suggestion importance[1-10]: 6__ Why: Relevant best practice - Keep API and documentation accurate and consistent by aligning comments/annotations with actual functionality. | Low |
| ||