[java] Remove obsolete variables from DriverCommand and W3CHttpCommandCodec
User description
🔗 Related Issues
Related to #10397
💥 What does this PR do?
changes to remove driver commands are the same as in the commit also rb and node bindings need similar changes
🔧 Implementation Notes
This pull request removes support for local storage and session storage commands from the Selenium WebDriver's W3C HTTP Command Codec. The changes streamline the codebase by eliminating unused or deprecated commands and their associated logic.
Removal of Local Storage and Session Storage Commands:
java/src/org/openqa/selenium/remote/DriverCommand.java: Removed constants for local storage and session storage commands, such asGET_LOCAL_STORAGE_ITEM,SET_LOCAL_STORAGE_ITEM, andCLEAR_SESSION_STORAGE.java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java: Removed import statements for local storage and session storage commands that were no longer needed. [1] [2]java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java: Removed alias definitions for local storage and session storage commands, which mapped these commands to JavaScript execution.java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java: Removed case statements and associated JavaScript logic for handling local storage and session storage commands. This includes commands likeCLEAR_LOCAL_STORAGE,GET_SESSION_STORAGE_KEYS, andSET_SESSION_STORAGE_ITEM.
💡 Additional Considerations
🔄 Types of changes
- Cleanup (formatting, renaming)
PR Type
Bug fix
Description
-
Remove deprecated HTML5 local storage and session storage commands
-
Clean up unused driver command constants and imports
-
Eliminate associated command codec aliases and implementations
-
Streamline W3C HTTP command codec for better maintainability
Changes diagram
flowchart LR
A["DriverCommand.java"] -- "Remove constants" --> B["Storage Commands Removed"]
C["W3CHttpCommandCodec.java"] -- "Remove imports" --> B
C -- "Remove aliases" --> B
C -- "Remove implementations" --> B
B --> D["Cleaner Codebase"]
Changes walkthrough 📝
| Relevant files | |||||
|---|---|---|---|---|---|
| Cleanup |
|
Need help?
Type /help how to ...in the comments thread for any questions about Qodo Merge usage.Check out the documentation for more information.
PR Reviewer Guide 🔍
Here are some key observations to aid the review process:
| ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪ |
| 🧪 No relevant tests |
| 🔒 No security concerns identified |
⚡ Recommended focus areas for reviewBreaking Change
|
PR Code Suggestions ✨
No code suggestions found for the PR.
@iampopovich The changes made and the PR title don't seem to align. Can you please update it?