[java][BiDi] implement web extensions

[Delta456]

User description

🔗 Related Issues

Implements https://github.com/SeleniumHQ/selenium/issues/15585

💥 What does this PR do?

Implements https://github.com/SeleniumHQ/selenium/issues/15585 for Java binding

🔧 Implementation Notes

The PR will fail on stable firefox and needs firefox to be 138 version as stated in https://github.com/SeleniumHQ/selenium/issues/15585#issuecomment-2782657812

💡 Additional Considerations

🔄 Types of changes

• New feature (non-breaking change which adds functionality and tests!)

---

PR Type

Enhancement, Tests

---

Description

• Add BiDi web extension install/uninstall API for Java

  • Implements webExtension.install and webExtension.uninstall commands
  • Supports extension install via path, archive, or base64

• Introduce new classes for extension data handling

• Add comprehensive tests for extension installation methods

• Update Bazel build files for new module and test integration

---

Changes walkthrough 📝

	Relevant files
Enhancement	7 files ExtensionArchivePath.java Add class for extension install via archive path                  +34/-0    ExtensionBase64Encoded.java Add class for extension install via base64 encoding            +34/-0    ExtensionData.java Add abstract base class for extension data types                  +24/-0    ExtensionPath.java Add class for extension install via directory path              +34/-0    InstallExtensionParameters.java Add parameters class for extension installation                    +31/-0    UninstallExtensionParameters.java Add parameters class for extension uninstallation                +29/-0    WebExtension.java Add main API for BiDi web extension install/uninstall        +50/-0
Configuration changes	5 files BUILD.bazel Add Bazel build file for webextension module                          +25/-0    BUILD.bazel Add webextension dependency to BiDi module build                  +1/-0      BUILD.bazel Add webextension dependency to remote module build              +1/-0      BUILD.bazel Add webextension dependency to BiDi input test build          +1/-0      BUILD.bazel Add Bazel build file for webextension tests                            +37/-0
Tests	1 files WebExtensionTest.java Add tests for BiDi web extension install/uninstall              +76/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review[bot]]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 15585 - PR Code Verified Compliant requirements: Implement WebDriver BiDi commands for installing and uninstalling web extensions Implement the following BiDi commands: webExtension.install webExtension.uninstall Requires further human verification: Support Chrome and Firefox implementations (PR mentions it will fail on stable Firefox and needs Firefox version 138)

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Variable Naming Inconsistency The test class uses inconsistent variable naming conventions. In some methods the WebExtension variable is capitalized (Extension) while in others it's lowercase (extension). WebExtension Extension = new WebExtension(driver); var ex = Assertion Style The tests use direct assert statements instead of more descriptive assertion libraries that would provide better failure messages. assert exIn.get("extension").equals(extensionData.get("id"));

[qodo-code-review[bot]]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Learned best practice	Add parameter null check Add a null check for the path parameter in the constructor to prevent NullPointerException. Use the Require utility class that's already being used elsewhere in the codebase to validate the input parameter. java/src/org/openqa/selenium/bidi/webextension/ExtensionArchivePath.java [25-27] public ExtensionArchivePath(String path) { - this.path = path; + this.path = org.openqa.selenium.internal.Require.nonNull("path", path); } [ ] Apply / Chat Suggestion importance[1-10]: 6 __ Why: Relevant best practice - Add null checks for parameters and properties before using them to prevent NullReferenceExceptions.	Low
General	Fix variable naming convention Variable naming convention is inconsistent. The variable Extension starts with an uppercase letter, which violates Java naming conventions. Use camelCase for variable names to maintain consistency with the rest of the codebase. java/test/org/openqa/selenium/bidi/webextension/WebExtensionTest.java [53-57] -WebExtension Extension = new WebExtension(driver); +WebExtension extension = new WebExtension(driver); var ex = - Extension.install( + extension.install( new InstallExtensionParameters(new ExtensionArchivePath(path.toString()))); assert ex.get("extension").equals(extensionData.get("id")); [ ] Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies and fixes a violation of Java variable naming conventions, improving code readability and maintainability, but it does not affect functionality or correctness.	Low
[ ] Update

[cgoldberg]

@Delta456 webextensions for Python are landing soon. It would be great to merge this also. Are you still just waiting for review? Can you drop a note on slack to ask for a reviewer?

[Delta456]

@Delta456 webextensions for Python are landing soon. It would be great to merge this also. Are you still just waiting for review? Can you drop a note on slack to ask for a reviewer?

Yes. I am still waiting for review. I have already asked on slack but I will do it just in case.

[cgoldberg]

I would help, but my Java is about as good as my Swahili

[shbenzer]

It's been a bit since I coded much in Java either lol, but after a cursory look it LGTM

[Delta456]

Could you please add some JavaDoc or explain in the PR description the approach you are using?

I had to read the code a few times to understand why we have InstallExtensionParameters and UninstallExtensionParameters. Somehow it seems like many classes to do this. Perhaps after reading the approach you are using I would understand this better.

I have used a class-based approach for InstallExtensionParameters and UninstallExtensionParameters because this has been used for other BiDi modules. I know there are so many for that, but I don't have a solution on how it can be reduced more.