selenium
selenium copied to clipboard
[java] increasing of properties scope for better appium compatibility
User description
Thanks for contributing to Selenium! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines. Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
according to request in #13949 scopes of properties were increased here's a part of request
Increase the scope of private properties of the below classes to 'protected':
RemoteWebDriver -> capabilities
HttpCommandExecutor -> commandCodec
HttpCommandExecutor -> responseCodec
FluentWait -> clock
FluentWait -> timeout
FluentWait -> interval
FluentWait -> sleeper
FluentWait -> ignoredExceptions
FluentWait -> messageSupplier
FluentWait -> input
Make public accessor for the property:
HttpCommandExecutor -> client
DriverService.Builder -> exe
Motivation and Context
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
- [x] I have read the contributing document.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
PR Type
Enhancement
Description
- Changed the access level of several fields in
HttpCommandExecutor
to improve compatibility with Appium:-
client
field changed to public. -
commandCodec
andresponseCodec
fields changed to protected.
-
- Changed the access level of the
capabilities
field inRemoteWebDriver
to protected. - Changed the access level of the
exe
field inDriverService.Builder
to public. - Changed the access level of multiple fields in
FluentWait
to protected:-
input
,clock
,sleeper
,timeout
,interval
,messageSupplier
,ignoredExceptions
.
-
Changes walkthrough 📝
Relevant files | |||||||||
---|---|---|---|---|---|---|---|---|---|
Enhancement |
|
💡 PR-Agent usage: Comment
/help
on the PR to get a list of all available PR-Agent tools and their descriptions