selenium icon indicating copy to clipboard operation
selenium copied to clipboard

Explicitly export Select and WebDriverWait from selenium.webdriver.support.ui

Open adamtheturtle opened this issue 5 months ago • 1 comments

Motivation and Context

Without this, mypy in strict mode gives:

Module "selenium.webdriver.support.ui" does not explicitly export attribute "Select"  [attr-defined]

when following the documentation at https://selenium-python.readthedocs.io/navigating.html#filling-in-forms.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] I have read the contributing document.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

adamtheturtle avatar Jan 23 '24 10:01 adamtheturtle

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (96e1411) 58.48% compared to head (2340a8d) 58.48%. Report is 15 commits behind head on trunk.

:exclamation: Current head 2340a8d differs from pull request most recent head c537ac0. Consider uploading reports for the commit c537ac0 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13491   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          86       86           
  Lines        5270     5271    +1     
  Branches      220      220           
=======================================
+ Hits         3082     3083    +1     
  Misses       1968     1968           
  Partials      220      220           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 23 '24 17:01 codecov-commenter