selenium icon indicating copy to clipboard operation
selenium copied to clipboard

Add return type to webelement.submit

Open adamtheturtle opened this issue 5 months ago • 2 comments

Motivation and Context

Without this, mypy in strict mode gives me the error:

Call to untyped function "submit" in typed context

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] I have read the contributing document.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

adamtheturtle avatar Jan 23 '24 10:01 adamtheturtle

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 23 '24 10:01 CLAassistant

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f9ff9b3) 58.48% compared to head (4b749fb) 58.57%. Report is 10 commits behind head on trunk.

:exclamation: Current head 4b749fb differs from pull request most recent head f1c7a38. Consider uploading reports for the commit f1c7a38 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13490      +/-   ##
==========================================
+ Coverage   58.48%   58.57%   +0.09%     
==========================================
  Files          86       86              
  Lines        5270     5270              
  Branches      220      220              
==========================================
+ Hits         3082     3087       +5     
+ Misses       1968     1963       -5     
  Partials      220      220              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 23 '24 17:01 codecov-commenter