selenium-google-code-issue-archive icon indicating copy to clipboard operation
selenium-google-code-issue-archive copied to clipboard

unclosed single quote + variable in locator causes unresponsive script

Open lukeis opened this issue 9 years ago • 4 comments

Originally reported on Google Code with ID 7833


What steps will reproduce the problem?
Running the following commands will cause Firefox to freeze:

<tr>
    <td>store</td>
    <td>[email protected]</td>
    <td>email</td>
</tr>
<tr>
    <td>assertElementPresent</td>
    <td>css=div.error:contains('${email} is taken)</td>
    <td></td>
</tr>

Eventually, Firefox will report:

"A script on this page may be busy, or it may have stopped responding. You can stop
the script now, open the script in the debugger, or let the script continue.

Script: chrome://selenium-ide/content/selenium-core/lib/sizzle.js:1"

Note that although
<td>css=div.error:contains('${email} is taken)</td>
crashes Firefox, 
<td>css=div.error:contains('${email} is taken')</td>
<td>css=div.error:contains(' is taken)</td>
<td>css=div.error:contains(' is taken')</td>

Do not.

I recently updated to Firefox 32, so maybe that's playing a role.

The short fix is to just close the single apostrophe, but this really shouldn't cause
Firefox to freeze up.

Selenium version: 2.6.0
OS: Windows 7
Browser: Firefox 32




Reported by [email protected] on 2014-09-03 22:56:18


- _Attachment: unresponsive_script.png
![unresponsive_script.png](https://storage.googleapis.com/google-code-attachments/selenium/issue-7833/comment-0/unresponsive_script.png)_

lukeis avatar Mar 04 '16 08:03 lukeis

Reported by barancev on 2014-09-04 18:55:49

  • Labels added: Component-IDE

lukeis avatar Mar 04 '16 08:03 lukeis

Hi,

Thank you for the report. I will try updating the sizzle library to see if it fixes
this issue.

Cheers,
Samit Badle
Selenium IDE Maintainer
Twitter: @samitbadle
Blog: http://blog.reallysimplethoughts.com/

Reported by Samit.Badle on 2014-09-16 06:48:29

  • Status changed: Accepted

lukeis avatar Mar 04 '16 08:03 lukeis

Please take into account that sizzle library is also used by InternetExplorerDriver
for old IE versions. So we have to run all IE tests carefully after sizzle upgrade.

Reported by barancev on 2014-09-16 08:54:24

lukeis avatar Mar 04 '16 08:03 lukeis

Reported by luke.semerau on 2015-09-17 17:47:05

  • Labels added: Restrict-AddIssueComment-Commit

lukeis avatar Mar 04 '16 08:03 lukeis