seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

fix(operator) close smoke test connection to scheduler

Open lynnmatrix opened this issue 1 year ago • 2 comments

What this PR does / why we need it: Seldon v2 operator does not close smoke test connection to scheduler.

Moreover, the scheduler server sends the current model status in SubscribeModelStatus request handler and then observes close event. If the subscriber cancels the stream immediately after sending the subscription request, the scheduler will not receive the cancellation message and will not delete the stream. so the scheduler should send current model status asynchronously in goroutine.

Which issue(s) this PR fixes:

Special notes for your reviewer:

lynnmatrix avatar Jan 16 '24 04:01 lynnmatrix

Hi @lynnmatrix. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Jan 16 '24 04:01 seldondev

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 12 '24 14:04 CLAassistant