seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

feat: Bump prometheus-client upperbound to 0.19.0

Open paiyar opened this issue 1 year ago • 3 comments

Background

Proposing that we bump the upper bound of the prometheus_client library required by the seldon-core python sdk to include the latest 0.19.0

Reasoning

We have projects that use the latest promethues_client library and are unable to use this library due to version restrictions:

pip._vendor.resolvelib.resolvers.ResolutionImpossible: [RequirementInformation(requirement=SpecifierRequirement('prometheus-client==0.17.1'), parent=None), RequirementInformation(requirement=SpecifierRequirement('prometheus-client<0.9.0,>=0.7.1'), parent=LinkCandidate('https://files.pythonhosted.org/packages/46/0a/261128eeae231b024aa0acf4f633be4c5b1f674e089298be360f338345b8/seldon_core-1.17.1-py3-none-any.whl (from https://pypi.org/simple/seldon-core/) (requires-python:>=3.6)'))]

paiyar avatar Jan 04 '24 18:01 paiyar

Hi @paiyar. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Jan 04 '24 18:01 seldondev

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 12 '24 14:04 CLAassistant

/ok-to-test

lc525 avatar Apr 16 '24 13:04 lc525