seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

Reduce sub process memory

Open ErraticO opened this issue 1 year ago • 2 comments

What this PR does / why we need it: Due to the independent memory space between processes, loading a model in a child process will result in loading multiple times. In the old way, if there were three child processes, the model would be loaded three times and the memory would increase by nearly three times. In the new way, load the model once in the parent process and then share it with the child process through Copy-On-Write (COW), with almost no increase in memory.

Which issue(s) this PR fixes:

Fixes # Fix memory increase caused by loading models in child processes.

Special notes for your reviewer:

ErraticO avatar Jan 03 '24 07:01 ErraticO

Hi @ErraticO. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Jan 03 '24 07:01 seldondev

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 12 '24 14:04 CLAassistant