seldon-core
seldon-core copied to clipboard
Allow protobuf 4
What this PR does / why we need it:
protobuf 3 is quite old. I want to use Python 3.11 and grpcio-tools, but grpcio-tools 1.49 which provides wheels for 3.11 (see this PyPI link) depends on protobuf 4.21.3 (see this link), which is not allowed by seldon-core 1.17.1.
It'd be appreciated if you could release the next version after this PR is merged as this is blocking me.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Hi @ysk24ok. Thanks for your PR.
I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.