seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

update missing value of MANAGER_LEADER_ELECTION_RETRY_PERIOD_SECS

Open saeid93 opened this issue 2 years ago • 3 comments

Fixes https://github.com/SeldonIO/seldon-core/issues/5086 and updated the missing value of MANAGER_LEADER_ELECTION_RETRY_PERIOD_SECS initiating the error mentioned in the issue. I followed the same value of similar fields https://github.com/SeldonIO/seldon-core/blob/b5b5a10979220a19da312bab138ad51341ef2f21/operator/config/manager/manager.yaml#L53

Alternatively, we can use the helm default values: https://github.com/SeldonIO/seldon-core/blob/b5b5a10979220a19da312bab138ad51341ef2f21/helm-charts/seldon-core-operator/values.yaml#L92 Plz let me know if that's preferred.

saeid93 avatar Aug 13 '23 20:08 saeid93

Hi @saeid93. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Aug 13 '23 20:08 seldondev

Hi @cliveseldon , is the error related to the commit? Doc tests are causing errors but as far as I understand the commits' changes are not linked to the doc.

saeid93 avatar Aug 15 '23 21:08 saeid93

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 12 '24 14:04 CLAassistant