Unable to configure ephemeral storage limit to Seldon core executor container

[dhinakaran7]

Describe the bug

I try to install seldon core components in a restricted environment where it is mandatory to specify ephemeral storage limit to any container that runs on it. CPU and memory request limits, I am able to pass through the below environment variables.

1. EXECUTOR_DEFAULT_CPU_REQUEST, 2. EXECUTOR_DEFAULT_MEMORY_REQUEST, 3.EXECUTOR_DEFAULT_CPU_LIMIT 4.EXECUTOR_DEFAULT_MEMORY_LIMIT.

Similarly, expected something like EXECUTOR_DEFAULT_EPHEMERAL_STORAGE_REQUEST EXECUTOR_DEFAULT_EPHEMERAL_STORAGE_LIMIT.

To reproduce

[ramanNarasimhan77]

I found that https://github.com/SeldonIO/seldon-core/blob/master/operator/controllers/seldondeployment_engine.go#L314 sets only Memory/CPU resource requests/limits.

There is no provision in Chart/code to add Ephemeral storage

[dhinasplace]

Hi,

Any comments on this behaviour ? If it is taken as a bug, any plan for the fix ?

[agrski]

Hi all,

The executor doesn't use any ephemeral storage, which is why it has never exposed that configuration previously.

If the requirement is simply to have this set, I think the simplest way forward would be to have hard-coded zero values for requests and limits. Any thoughts on why this wouldn't be suitable?

[dhinasplace]

Hi @agrski

Thanks for your response.

Yes hardcoding is fine. In my understanding, hardcoding will also require a code change.

As indicated by @ramanNarasimhan77 , https://github.com/SeldonIO/seldon-core/blob/master/operator/controllers/seldondeployment_engine.go#L314, there is no provision in Chart/code to add Ephemeral storage.