seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

Add meta arg in grpc_predict_seldon()

Open ysk24ok opened this issue 2 years ago • 3 comments

What this PR does / why we need it:

SSIA

rest_predict_seldon(), rest_predict_gateway() and grpc_predict_gateway() have meta argument, but only grpc_predict_seldon() doesn't have it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

ysk24ok avatar Jul 06 '23 10:07 ysk24ok

Hi @ysk24ok. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Jul 06 '23 10:07 seldondev

/ok-to-test

ukclivecox avatar Jul 06 '23 10:07 ukclivecox

@cliveseldon Could you review again?

ysk24ok avatar Aug 01 '23 10:08 ysk24ok