seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

Fix Python Server Configuration doc

Open ysk24ok opened this issue 2 years ago • 4 comments

What this PR does / why we need it:

  • df59190e0956e1f6b0bc1511b1635fa8a3448820 Fixed incorrect env vars for some --parameters and --log-level options.
  • 7cb8800eccd809dacc4161f41a63b77e16af7c0b Added missing gRPC options

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

ysk24ok avatar Jul 06 '23 10:07 ysk24ok

Hi @ysk24ok. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Jul 06 '23 10:07 seldondev

/ok-to-test

ukclivecox avatar Jul 06 '23 10:07 ukclivecox

https://github.com/SeldonIO/seldon-core/actions/runs/5474134226/jobs/9969171037?pr=4985

! grep -v '429' _build/output.txt | grep 'broken'
examples/global-rclone-upgrade.nblink:13: [broken] https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html: 404 Client Error: Not Found for url: https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html
examples/rclone-upgrade.nblink:13: [broken] https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html: 404 Client Error: Not Found for url: https://docs.seldon.io/projects/seldon-core/en/latest/servers/kfserving-storage-initializer.html
make: *** [Makefile:42: linkcheck] Error 1

Hmm it doesn't seem to be caused by this PR?

ysk24ok avatar Jul 06 '23 10:07 ysk24ok

@cliveseldon Could you review again?

ysk24ok avatar Aug 01 '23 10:08 ysk24ok