SeldonIO
Seldon v2: Helm chart missing variables and a protocol: TCP
Describe the bug
In the Helm chart, I have no possibility to add my labels/annotations/nodeSelector/tolerations/affinity/anti-affinity ...
Furthermore, there's protocol: TCP missing line 1661 in file seldon-v2-components.yaml
Argocd is raising an error, preventing a good sync of the apps
To reproduce
Deploy seldon v2 setup with argocd. try to add labels/annotations ... in the value file
Expected behaviour
Be able to add my own labels/annotations/... to any seldon resources Seldon helm chart running with argocd without issues
Environment
- Cloud Provider: AWS EKS
- Kubernetes Cluster Version: 1.24
- Deployed Seldon System Images: 2.5.0
@FredericJames could you provide example of how you see extending the Helm charts without ArgoCD in the picture?
We're using argocd and won't be able to do otherwise. Right now, the missing field protocol is preventing me to use argocd properly. So I have to kustomize this helm chart to patch the manifest
This seems strange as TCP is the default. This is also defined with a default inside the CRD also. Maybe ArgoCD does not handle CRD defaults?
+1 for tolerations, nodeSelectors, et al. in the Helm chart. We're using Seldon Core V2, and would like to be able to deploy everything to its own node pool without the need for patching the yaml after the Helm deploy.
