seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

Inject storage initializer on not prepacked server

Open cnfatal opened this issue 3 years ago • 5 comments

Added Storage Initializers on not prepacked server.

What this PR does / why we need it:

Enable storage initalizer inject when modelUri set in graph on not prepacked server.

Which issue(s) this PR fixes:

Fixes #4251

Special notes for your reviewer:

A test already added.

cnfatal avatar Aug 03 '22 05:08 cnfatal

Hi @cnfatal. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Aug 03 '22 05:08 seldondev

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign rafalskolasinski You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

seldondev avatar Aug 03 '22 05:08 seldondev

Hi @cnfatal, could you post example manifest how you see it being used?

RafalSkolasinski avatar Aug 04 '22 12:08 RafalSkolasinski

Hi @cnfatal, could you post example manifest how you see it being used?

There are some my cases: https://github.com/SeldonIO/seldon-core/issues/4251#issuecomment-1207699328

cnfatal avatar Aug 08 '22 05:08 cnfatal

Hi @axsaucedo ,It's My fault, I resolved them in a new commit. Could you please have a look once more.

cnfatal avatar Aug 08 '22 06:08 cnfatal

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 25 '22 02:10 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Nov 05 '22 02:11 github-actions[bot]