seldon-core
seldon-core copied to clipboard
SeldonIO
Fix for hard-coded service account name in rolebindings
What this PR does / why we need it:
There is a problem with the service account name usage in templates. It's not possible to change the name from the default "seldon-manager" to something else, because in deployment phase this error occurs:
"Error creating: pods "seldon-controller-manager-xxx-" is forbidden: error looking up service account xxx/seldon-manager: serviceaccount "seldon-manager" not found".
So the fix is to use the name from the serviceAccount.name variable defined in values.yaml instead of the hard-coded one.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Hi @BlaD200. Thanks for your PR.
I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign majolo
You can assign the PR to them by writing /assign @majolo in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Closing for the time being but we can explore adding on the split resource file in the near future if you get a chance