seldon-core icon indicating copy to clipboard operation
seldon-core copied to clipboard

fix deployment match value change.

Open guhan121 opened this issue 2 years ago • 3 comments

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4132

Special notes for your reviewer:

guhan121 avatar Jun 01 '22 10:06 guhan121

Hi @guhan121. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

seldondev avatar Jun 01 '22 10:06 seldondev

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign agrski You can assign the PR to them by writing /assign @agrski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

seldondev avatar Jun 01 '22 10:06 seldondev

/assign @agrski

guhan121 avatar Jun 01 '22 11:06 guhan121

Closing as discussed in #4132, we can reopen based on discussion

axsaucedo avatar Sep 05 '22 10:09 axsaucedo