seldon-core
seldon-core copied to clipboard
Extend `drift_batch_size` logic in `adserver`
Currently the fixed drift_batch_size set by the user can result in batches bigger than the threshold to be fed through the detector: https://github.com/SeldonIO/seldon-core/blob/master/components/alibi-detect-server/adserver/cd_model.py#L89
The default behaviour should be that if there are more than drift_batch_size requests, only the first drift_batch_size requests should be put through a detector and the rest delegated to the next drift event. This ensures that drift batch sizes are consistent wrt user expectation.
Out-of-scope Useful to have in mind - long-term extend ability to form batches over pre-defined time windows instead of pre-defined batch sizes.