alibi-detect icon indicating copy to clipboard operation
alibi-detect copied to clipboard

Dev/upgrade prophet 1.1

Open jklaise opened this issue 1 year ago • 5 comments

Resolves #626.

Went straight to 1.1 as they have nice things:

  • No dependency on pystan due to stopped development, the stan backend used now is cmdstanpy
  • Wheels provided for all major platforms and Python versions so no installation woes, means we should be able to run Windows tests

I've tested also that the sole example notebooks works as expected.

jklaise avatar Sep 21 '22 16:09 jklaise

Codecov Report

Merging #627 (341af20) into master (6274a96) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 341af20 differs from pull request most recent head c1531dc. Consider uploading reports for the commit c1531dc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files         123      123           
  Lines        8749     8749           
=======================================
  Hits         6821     6821           
  Misses       1928     1928           
Flag Coverage Δ
macos-latest-3.10.6 74.54% <ø> (ø)
ubuntu-latest-3.10.6 77.34% <ø> (ø)
ubuntu-latest-3.7 77.75% <ø> (ø)
ubuntu-latest-3.8 77.79% <ø> (ø)
ubuntu-latest-3.9 77.79% <ø> (ø)
windows-latest-3.9 74.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov-commenter avatar Sep 21 '22 17:09 codecov-commenter

  • No dependency on pystan due to stopped development, the stan backend used now is cmdstanpy
  • Wheels provided for all major platforms and Python versions so no installation woes, means we should be able to run Windows tests

These would both be great!

ascillitoe avatar Sep 21 '22 17:09 ascillitoe

I've also updated the changelog (note removal of a couple of extraneous lines from previous releases).

Also note that I've manually checked the save/load functionality still works (we don't have a test for it, happy to add?).

jklaise avatar Sep 22 '22 08:09 jklaise

Also note that I've manually checked the save/load functionality still works (we don't have a test for it, happy to add?).

When you say save/load functionality, what are you referring to? Saving and loading OutlierProphet via save_detector and load_detector?

ascillitoe avatar Sep 22 '22 10:09 ascillitoe

Also note that I've manually checked the save/load functionality still works (we don't have a test for it, happy to add?).

When you say save/load functionality, what are you referring to? Saving and loading OutlierProphet via save_detector and load_detector?

Yup, that's the one.

jklaise avatar Sep 22 '22 10:09 jklaise

When you say save/load functionality, what are you referring to? Saving and loading OutlierProphet via save_detector and load_detector?

Yup, that's the one.

There is actually one test for it in the legacy save/load tests (since outlier detectors are still saved in the legacy format):

https://github.com/SeldonIO/alibi-detect/blob/341af20c5e7e33ab46a206e1d2313c0465380085/alibi_detect/utils/tests/test_saving_legacy.py#L137-L141

We'll need to write a new one in saving/tests/test_saving.py once we've updated serialization for outlier detectors.

ascillitoe avatar Sep 23 '22 08:09 ascillitoe