monolog icon indicating copy to clipboard operation
monolog copied to clipboard

Fluentd formatter: format as dictionnary for Record Accessor support

Open sbocahu opened this issue 4 years ago • 2 comments

Fluentbit, a lightweight Fluentd shipper, only supports dictionnary records for its record accessor functionnality ( https://docs.fluentbit.io/manual/administration/configuring-fluent-bit/record-accessor ) Using keys instead of array indexes is generally easier and less error-prone in any case. This PR changes the Fluentd formatting to return a dictionnary instead of an array.

sbocahu avatar Feb 04 '21 10:02 sbocahu

Two issues I have here:

  • The tests are broken
  • This may not be backwards compatible? I am not knowledgeable enough about Fluentd to say if this would cause issues for existing setups?

Seldaek avatar Apr 04 '21 14:04 Seldaek

@Seldaek Test file corruption is normal. This requires new controls and is unnecessary, there is no situation that will cause an error right now. I think this withdrawal request should not be sent.

selcukcukur avatar Apr 07 '21 16:04 selcukcukur