Jordi Boggiano

Results 890 comments of Jordi Boggiano

Yes it seems safe, but it doesn't solve the problem in the other PR :) > I also think that people will use it with the `::class` syntax rather than...

Sorry you lost me there. You already have `->enumFqcn()` so it is clear that what is passed in there must be a valid enum class name, and enum_exists will ensure...

The default version if no other version can be guessed is dev-main, so why not require dev-main in your main composer.json? Or you can set a version explicitly in path/to/package/composer.json

> Maybe the double-realpath call should be moved into `Platform::realpath()` and the `Platform::getCwd()` should always return its `realpath()`? Per the linked bug yes maybe we should always realpath n+1 times...

Sorry I'm also way behind reviewing here, but I'll try to get to it, if there is a specific question blocking you let me know.

I think in theory I have nothing against the idea, but I'm probably not gonna spend time on this myself. Look at VersionGuesser::guessGitVersion if you want to add this.

I'd recommend using https://github.com/staabm/phpstan-dba additionally which resolves types much narrower for most queries.

Please see #12263 for an alternative fix, which I believe is more correct and appears to resolve the issue as well by forcing a stable order.

I think better than a simple alphabetical sort, for the commands, config and schema pages, would be to create sub-groups with meaningful names because one long flat list is anyway...

IMO all in one monolog.yaml is clearer so you have the overview and are less likely to do such mistakes.. `when@dev:` syntax lets you split env specific configs in the...