sekai-viewer icon indicating copy to clipboard operation
sekai-viewer copied to clipboard

Published 20 hours ago • verified publisher icon Sekai-World

feat(Story Reader Live2d)

Open kyokuheishin opened this issue 3 years ago • 8 comments

Description

Implemented the Live2D version of Story Reader.

Related Issue

N/A

Motivation and Context

Since the Live2D reader has been unavailable for quite a long time, so I implemented it.

How Has This Been Tested?

  • [X] Chrome (Desktop)
  • [X] Firefox (Desktop)

Screenshots (if appropriate):

image image image

Details

Features Implemented:

  • Some Basic Special Effects (Changing background image, play music, black/white in/out, dialogue, etc.)
  • Live2D model displaying, changing motion/expression

TODO:

  • Better UI
  • More Special Effects
  • Lip sync

kyokuheishin avatar Feb 10 '22 05:02 kyokuheishin

Thanks for your efforts! I will review it asap

dnaroma avatar Feb 10 '22 15:02 dnaroma

Hi, I reviewed your work, it's pretty awesome, but some suggestions:

  1. Rename "Show" button to "Load".
  2. Add progress bar to indicate loading progress.
  3. Show "START!" on canvas before start instead of hint text above.
  4. Some model keeps T-pose, motion not applied.
  5. Add "Auto" button or checkbox to allow auto play.

Because too many bugs still exist, I can't approve it for merge it.

dnaroma avatar Feb 26 '22 14:02 dnaroma

  1. Rename "Show" button to "Load".
  2. Add progress bar to indicate loading progress.
  3. Show "START!" on canvas before start instead of hint text above.
  4. Some model keeps T-pose, motion not applied.
  5. Add "Auto" button or checkbox to allow auto play.

Sorry for not replying for so long, I've been a bit busy lately. Thanks for the review! I've made several UI changes that you suggested. But regarding the T-pose issue, I confirmed that the model loaded the action successfully and the issue only occurs when there are many ( n>= 8 ) characters appearing in a story at the same time, so I think it might be related to the third-party library I'm using. It may take me a while to verify my suspicions.

kyokuheishin avatar Mar 12 '22 08:03 kyokuheishin

Still cannot find why loading 10 models could cause animation not updated, it may be a WebGL performance issue.

The solution now is, to create or destroy the model every time the scenario script tells it to appear or disappear, instead of keeping them in memory.

kyokuheishin avatar May 11 '22 10:05 kyokuheishin

Is Story Reader Live2D still working?

LazytownSpo666 avatar Apr 04 '24 08:04 LazytownSpo666

Is Story Reader Live2D still working?

Seems so

dnaroma avatar Apr 06 '24 14:04 dnaroma

Is Story Reader Live2D still working?

Seems so

if it does work, what will you (or anyone) need to run Story Reader Live2D? (Also it's not working on any phone)

LazytownSpo666 avatar Apr 06 '24 14:04 LazytownSpo666

Is Story Reader Live2D still working?

Seems so

if it does work, what will you (or anyone) need to run Story Reader Live2D?

(Also it's not working on any phone)

Have you tested this branch? I'm not sure if it's still working. As long as you can use current Live2D viewer, you could use the Live2D story reader as well.

dnaroma avatar Apr 06 '24 18:04 dnaroma

Is this feature complete or not?

Also what happened to author of this pull request?!

LazytownSpo666 avatar May 28 '24 12:05 LazytownSpo666