dr/rename parameters

[sebwolf-de]

This PR is supposed to start a discussion about how we name our parameters. All in all it is a big mess:

• paramters.par is case-insensitive
• fault.yaml/material.yaml is case-sensitive
• Some parameters had a prefix like TP_alpha_hy or RS_a.
• Other like v_star did not.
• Wild mixture between camel_case and snakeCase (:wink:)

During the implementation of dr/cpp @ravil-mobile and I tried to make names more verbose, if possible. At the same time larger changes make it more difficult for users to adapt their models.

[codecov-commenter]

Codecov Report

Merging #632 (519db35) into dr/cpp (276f1e9) will not change coverage. The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           dr/cpp    #632   +/-   ##
======================================
  Coverage    9.81%   9.81%           
======================================
  Files         260     260           
  Lines       17977   17977           
======================================
  Hits         1764    1764           
  Misses      16213   16213           

Impacted Files	Coverage Δ
...icRupture/Initializers/RateAndStateInitializer.cpp	0.00% <0.00%> (ø)
src/DynamicRupture/Parameters.h	0.00% <0.00%> (ø)
src/Numerical_aux/typesdef.f90	0.00% <ø> (ø)
src/Reader/readpar.f90	0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Thomas-Ulrich]

I mean change thermal to hydraulic

Le 28 juillet 2022 08:53:21 GMT+02:00, Sebastian Wolf @.> a écrit : @. commented on this pull request.

@@ -299,20 +299,44 @@ The TP parameters for which no spatial dependence has been implemented are defin

&DynamicRupture thermalPress = 1 ! Thermal pressurization 0: inactive; 1: active

• IniTemp = 483.15 ! Initial temperature [K]
• IniPressure = -80.0e6 ! Initial pore pressure; have to be added to normal stress in your initial stress yaml file [Pa]
• alpha_th = 1.0e-6 ! Thermal diffusivity [m^2/s]
• rho_c = 2.7e6 ! Specific heat [Pa/K]
• TP_lambda = 0.1e6 ! Pore pressure change per unit temperature [Pa/K]

• TP_IniTemp = 483.15 ! Initial temperature [K]
• TP_IniPressure = -80.0e6 ! Initial pore pressure; have to be added to normal stress in your initial stress yaml file [Pa]
• TP_hydraulicDiffusivity = 1.0e-6 ! Thermal diffusivity [m^2/s]

parameters.par is case-insensitive ;-)

-- Reply to this email directly or view it on GitHub: https://github.com/SeisSol/SeisSol/pull/632#discussion_r931844436 You are receiving this because your review was requested.

Message ID: @.***>