Andreas Schleifer

Results 33 comments of Andreas Schleifer

The problem is that the `git symbolic-ref HEAD` command also found the branch name and that is used later. so either I have to add another command to run or...

My suggested fix for this: ```diff diff --git a/gitstatus.py b/gitstatus.py index d944fd4..28bdad4 100755 --- a/gitstatus.py +++ b/gitstatus.py @@ -12,7 +12,7 @@ branch, error = gitsym.communicate() error_string = error.decode('utf-8') -if 'fatal:...

check what the output of `git symbolic-ref HEAD` is on your system. I see this as an error that the python script doesn't realize there is no repository.

Hm this should work. did you apply the entire change? the lowercasing of the first string and the `.lower()` function at the end?

That is not enough. According to https://github.com/olivierverdier/zsh-git-prompt/pull/117 he only added the `.lower()` call at the end, but the "N" of "fatal: Not a git repository" is still uppercase. So essentially...

Upon thinking more about this and reading above that some people have non-english system, maybe it makes more sense not to check the error string, but the return code of...

This is still an issue to date with version 6.4.2. I would hate to have to disable the entire test on arch linux packaging, but stable tests would be appreciated....

``` ruby 3.0.4p208 (2022-04-12 revision 3fa771dded) [x86_64-linux] ``` ``` RubyGems Environment: - RUBYGEMS VERSION: 3.3.23 - RUBY VERSION: 3.0.4 (2022-04-12 patchlevel 208) [x86_64-linux] - INSTALLATION DIRECTORY: /usr/lib/ruby/gems/3.0.0 - USER INSTALLATION...

I'm one of the ruby maintainers for Arch Linux and we are currently rebuilding all packages against ruby 3.2 in our [extra-staging] repository and there I saw the issue. You...

I should mention I tried to build with version `28.0.0` of this gem here.