ArduinoCore-samd icon indicating copy to clipboard operation
ArduinoCore-samd copied to clipboard

XIAO_m0/variant.h: Fix syntax error due to bee0a78a

Open bxparks opened this issue 2 years ago • 3 comments

Commit bee0a78a left behind some code fragment which causes a syntax error. The compiler error message is:

.../Seeeduino/hardware/samd/1.8.4/variants/XIAO_m0/variant.h:219:25:
warning: extra tokens at end of #endif directive [-Wendif-labels]

The code that bee0a78a partially deleted was:

  #define Serial SerialUSB

I think the fix is to remove the whole thing, instead of adding it back, because I think TinyUSB provides its Serial instance. Verified to work on the XIAO M0 with this line removed.

bxparks avatar Jun 01 '23 02:06 bxparks

This has been giving me trouble as well. Anything holding this back from being merged? It's a very simple syntax fix and shouldn't need any code review, just needs someone to click the merge button... 😄

JonnyHaystack avatar Aug 04 '23 18:08 JonnyHaystack

I had 2-3 additional fixes and improvements that I wanted to add to Seeeduino, but if something as trivial as this one-line fix is neglected, no point in sending additional PRs. Which is too bad because the XIAO hardware line seemed very interesting, and I was going to expand support to those other XIAO boards. But not anymore. I've learned that without good software support, the hardware is a waste of time and money no matter good it is.

bxparks avatar Aug 05 '23 15:08 bxparks

This fix is already present via https://github.com/Seeed-Studio/ArduinoCore-samd/commit/f6bb825019705413ecc901f78ee6327191888278

pfeerick avatar Dec 10 '23 04:12 pfeerick