django-react-redux-base icon indicating copy to clipboard operation
django-react-redux-base copied to clipboard

Upgraded to Django 2.2.1 & DRF 3.9 plus some other package upgrades with minor changes.

Open kooshan75 opened this issue 5 years ago • 4 comments

Fixes #115 & #111. Upgraded almost every package to its latest release and migrated to Django 2.2.1 & DRF 3.9. Changed two incompatible packages that the project was using them:

django-disposable-email-checker

Which did not support Django 2.2.1, I switched it to email_validator, which almost has the same functionality.

django-rest-knox==3.0.3

Which was incompatible, I switched it to a more reliable and known package called django-rest-auth and moved to its Token Authentication method.

kooshan75 avatar Jun 04 '19 02:06 kooshan75

I'm also planning to complete the implementation of test files and committing them in the next couple of days since I've run tests manually.

kooshan75 avatar Jun 04 '19 02:06 kooshan75

I'm also planning to complete the implementation of test files and committing them in the next couple of days since I've run tests manually.

Done. All tests were successful & ./scripts/test_local_backend.sh returns that all tests have passed. @abossard @lfrodrigues @pconerly @andrealmar @DFilipeS

I'd be honored if you guys could review my code.

kooshan75 avatar Jun 04 '19 11:06 kooshan75

Other than the travis build failing because of #120 looks like i would be best to use this if starting a fresh project @kooshan75 ?

gwsampso avatar Jul 12 '19 06:07 gwsampso

Other than the travis build failing because of #120 looks like i would be best to use this if starting a fresh project @kooshan75 ?

Yes of course. The old version of this project doesn't support lots of services.

kooshan75 avatar Jul 12 '19 15:07 kooshan75